Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for both new and legacy ID types on product selection page #134

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

nii-mants3
Copy link
Contributor

@nii-mants3 nii-mants3 commented Nov 17, 2023

Currently we only check the legacy ID types on the production selection screen which limits jobs especially from Smile Links that now use the new ID types. This PR fixes that by checking for both the new and legacy ID types.

@nii-mants3 nii-mants3 self-assigned this Nov 17, 2023
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Components / Smart Camera Web:
https://cdn.smileidentity.com/js/preview-prod-selc-docv/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-prod-selc-docv/js/script.min.js

@nii-mants3 nii-mants3 marked this pull request as ready for review November 17, 2023 08:59
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Components / Smart Camera Web:
https://cdn.smileidentity.com/js/preview-prod-selc-docv/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-prod-selc-docv/js/script.min.js

Copy link
Contributor

@tamssokari tamssokari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@nii-mants3 nii-mants3 merged commit 71b20a1 into main Nov 17, 2023
9 checks passed
@nii-mants3 nii-mants3 deleted the prod-selc-docv branch November 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants